Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

S3 buckets and Circle CI export script #167

Merged
merged 5 commits into from
Nov 23, 2020
Merged

S3 buckets and Circle CI export script #167

merged 5 commits into from
Nov 23, 2020
+529 −2

Conversation

SarahJaine
Copy link
Contributor

@SarahJaine SarahJaine commented Nov 23, 2020 •
edited by rahearn
Loading

Description of change
Merges

Description of change
for adhocteam#72

  • Update terraform code to create s3 buckets to use for document upload (a field in the activity report)
  • Create service binding for s3 buckets

How to test
for adhocteam#72

Issue(s)

Checklist

  • Meets issue criteria
  • Code tested
  • Meets accessibility standards (WCAG 2.1 Levels A, AA)
  • Documentation updated

rahearn and others added 5 commits November 10, 2020 13:21
@rahearn
Add circleci export script
bb66732
@rahearn
Include cucumber screenshots in the artifacts list
b8ee6f3
@rahearn
Merge branch 'main' into circleci-export
31e4ed9 
* main: (38 commits)
  CD: Bind RDS instance (#71)
  Update test
  init sandbox tf env (#70)
  Remove comments
  Update tests
  Update tests
  Update tests
  Add constants; other changes
  Remove unused import
  Remove placeholder and unnecessary fragment
  Remove max workers
  Add deletions after each test
  Remove comment
  Update api doc
  Add user admin validation
  Add forgotten change
  Create the admin API doc
  Set sandbox branch
  Add multiselect component
  Update the erd diagram
  ...
@rahearn
Merge pull request #65 from HHS/circleci-export
02071b8 
CircleCI results export script
@SarahJaine
Terraform: Create S3 bucket for doc upload (#72)
5f5fc52 
* add service instance

* add binding

* correct service binding

* add bucket to sand, stag, prod

* take out rds bind

Co-authored-by: Sarah-Jaine Szekeresh <[email protected]>
rahearn
rahearn approved these changes Nov 23, 2020
View reviewed changes
Copy link
Contributor

@rahearn rahearn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@rahearn
Copy link
Contributor

rahearn commented Nov 23, 2020 •
edited
Loading 

└─> terraform apply
data.cloudfoundry_service.s3: Refreshing state...
data.cloudfoundry_space.space: Refreshing state... [id=e1fb8eaa-a857-42f0-a46f-7c08da3dfbaa]
data.cloudfoundry_service.rds: Refreshing state... [id=dcfb1d43-f22c-42d3-962c-7ae04eda24e7]
cloudfoundry_service_instance.database: Refreshing state... [id=2bcbcb23-9f3b-44f1-9b37-5d7554d02c3e]

An execution plan has been generated and is shown below.
Resource actions are indicated with the following symbols:
  + create

Terraform will perform the following actions:

  # cloudfoundry_service_instance.document_upload_bucket will be created
  + resource "cloudfoundry_service_instance" "document_upload_bucket" {
      + id               = (known after apply)
      + name             = "ttahub-document-upload-staging"
      + recursive_delete = false
      + service_plan     = "021bb2a3-7e11-4fc2-b06b-d9f5938cd806"
      + space            = "e1fb8eaa-a857-42f0-a46f-7c08da3dfbaa"
    }

Plan: 1 to add, 0 to change, 0 to destroy.

Do you want to perform these actions?
  Terraform will perform the actions described above.
  Only 'yes' will be accepted to approve.

  Enter a value: yes

cloudfoundry_service_instance.document_upload_bucket: Creating...
cloudfoundry_service_instance.document_upload_bucket: Creation complete after 6s [id=d06e38cf-81ee-4568-977c-5c5bd1a15cee]

Apply complete! Resources: 1 added, 0 changed, 0 destroyed.

@rahearn rahearn merged commit 3934c1e into HHS:main Nov 23, 2020
rahearn pushed a commit that referenced this pull request Feb 17, 2021
@dcmcand
Merge pull request #167 from adhocteam/cm-204-add-file-queue
ad7bcdd 
Cm 204 add file queue components to backend app
dcmcand pushed a commit that referenced this pull request Feb 22, 2021
Squashed commit of the following:
3b79b27 
commit ad7bcdd
Merge: 74a8308 4c04457
Author: Chuck McAndrew <[email protected]>
Date:   Wed Feb 17 13:05:43 2021 -0500

    Merge pull request #167 from adhocteam/cm-204-add-file-queue

    Cm 204 add file queue components to backend app

commit 4c04457
Author: Chuck McAndrew <[email protected]>
Date:   Wed Feb 17 11:57:54 2021 -0500

    update handler.test.js and switch to auditLogger
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rahearn rahearn rahearn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create s3 buckets for document upload endpoint Figure out workaround for CircleCI access issues
2 participants
@SarahJaine @rahearn